Client Side Caching #2854
Draft
Client Side Caching #2854
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sjpotter
commented
Nov 4, 2024
sjpotter
commented
Nov 4, 2024
sjpotter
commented
Nov 4, 2024
sjpotter
commented
Nov 4, 2024
sjpotter
commented
Nov 4, 2024
sjpotter
commented
Nov 4, 2024
| @@ -218,6 +231,7 @@ export default class RedisClusterSlots< | |||
| } | |||
|
|
|||
| await Promise.all(promises); | |||
| this.clientSideCache?.enable(); | |||
There was a problem hiding this comment.
need to think about this clear/disable/enable.
There was a problem hiding this comment.
so the reason I did disabled/enabled as I did, as while nothing could change, topology (master/replicas, slot mapping) could change without any clients being added.
this concerns me and make me think that on any reconfigure we have to clear cache. I'm not sure the order matters as the only "await" seems to be the await Promises.all() so moving them around wont effect much I think.
sjpotter
commented
Nov 4, 2024
sjpotter
commented
Nov 4, 2024
sjpotter
force-pushed
the
csc-1
branch
4 times, most recently
from
63601a1
to
ff9fca2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Checklist
npm testpass with this change (including linting)?