Rewrite createClient. Fixes #651 #786
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| var parsed = URL.parse(arg0, true, true), | ||
| options = (arg1 || {}); | ||
|
|
||
| var parsed = URL.parse(arg0, true, true); |
There was a problem hiding this comment.
It looks like URL.parse does not return a parsed.port when the string is only a string number like "6379", so this introduces breaking changes. Am I wrong?
erin@elisheva:~/node_redis$ node -e "var URL = require('url'); console.log(URL.parse('8000'));"
{ protocol: null,
slashes: null,
auth: null,
host: null,
port: null,
hostname: null,
hash: null,
search: null,
query: null,
pathname: '8000',
path: '8000',
href: '8000' }
There was a problem hiding this comment.
I did not test every possibility and would like to add some before this is merged but I'm quite certain the behavior is just the same as it was before. There should not be any BC.
This code is the same as it was before in line 1245.
There was a problem hiding this comment.
Doh, you're right. Looks like this bug predates your PR. Also, all of the new mocha tests (which test all applicable combinations of ipv4, ipv6, hiredis, javascript, and unix sockets) pass against this.
erinishimoticha
added a commit
that referenced
this pull request
Jul 22, 2015
Rewrite createClient. Fixes #651
This was referenced Jul 22, 2015
This was referenced Oct 17, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'd like to add some tests for it but the test suite right now is not really suitable as I see it. So this should probably wait until the mocha tests got merged as planned.