adding proper translation for DateTimeOffsets #406
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imansafari1991
approved these changes
Aug 11, 2023
…GH only unit tests
|
Determined that this is a pretty similar issue to #391 - so fixing that as well. |
shacharPash
approved these changes
Aug 16, 2023
| namespace Redis.OM.Unit.Tests; | ||
|
|
||
| [AttributeUsage(AttributeTargets.Method, AllowMultiple = false)] | ||
| public class SkipIfMissingEnvVarAttribute : FactAttribute |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #395
As it stands now DateTimeOffsets are not being parsed correctly in queries, DateTimes are converted to UNIX timestamps before being submitted to a query (based on the local timezone). Using
DateTimeOffsetsis the 'more correct' way to run date ranges (as it has all the timezone information needed to make an informed decision. The challenge was that you couldn't actually use those in your queries before. This fixes that.