-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Permanent saving of some types #471
Conversation
ea3ed1a
to
875c3e7
Compare
875c3e7
to
7790e97
Compare
@slorello89 I don`t understand what it's happened. Local this tests works fine |
@granit1986 - it looks like you are encountering an issue with timezones, I don't think there's anything wrong with thow the code is operating at least insofar as I'm able to revert your changes and still have those tests pass. |
Great. Thank you. I think we can leave it like this. |
@granit1986 - my point was that given I'm able to revert your code changes and still have your tests pass, I don't know that this PR is necessary? |
I was hoping that these fixes would make it into the main repository. |
@granit1986 - I understand, but your tests pass against the original code base, so it's unclear what's being fixed by them, it sounds more like you were having a timezone issue with your DateTimes then an actual defect in Redis OM. |
I understand. I will try fix test for new case |
collection.Update(item); | ||
|
||
var timestamp = new DateTimeOffset(dateTime).ToUnixTimeMilliseconds(); | ||
_substitute.Received(0).Execute( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@slorello89 i changed test.
here it is implied that the date update should not occur if the value has not changed
# Conflicts: # README.md
Several types such as
DateTime
,byte[]
which are different from redis types, were always detected as modified and saved