Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Was investigating #562 when I discovered to my dismay that
HashModels
now fail if they encounter aNone
. The genesis of this is thedict
method in pydantic which produced''
as the default value if the value for a string field wasNone
, changed in pydantic 2.x, now it simply returnsNone
if no default is specified. Now this wouldn't be a problem except for the fact that redis-py cannot handle aNone
value inHSET
(fair enough).Altering the behavior to exclude
None
type fromHSET
command, while still allowing you to define a default value for the field.redis-om-py 0.2.x behavior:
None
types in a hash default to''
redis-om-py 0.3.0 behavior:
None
type fails in a hashnew behavior:
None
is justNone