Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

single page per page call #624

Merged
merged 6 commits into from
May 31, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion aredis_om/model/model.py
Original file line number Diff line number Diff line change
Expand Up @@ -948,7 +948,9 @@ async def all(self, batch_size=DEFAULT_PAGE_SIZE):
return await self.execute()

async def page(self, offset=0, limit=10):
return await self.copy(offset=offset, limit=limit).execute()
return await self.copy(offset=offset, limit=limit).execute(
exhaust_results=False
)

def sort_by(self, *fields: str):
if not fields:
Expand Down
12 changes: 7 additions & 5 deletions tests/test_hash_model.py
Original file line number Diff line number Diff line change
Expand Up @@ -389,8 +389,10 @@ async def test_sorting(members, m):
async def test_case_sensitive(members, m):
member1, member2, member3 = members

actual = await m.Member.find(m.Member.first_name == "Andrew").all()
assert actual == [member1, member3]
actual = await m.Member.find(
m.Member.first_name == "Andrew" and m.Member.pk == member1.pk
).all()
assert actual == [member1]

actual = await m.Member.find(m.Member.first_name == "andrew").all()
assert actual == []
Expand Down Expand Up @@ -859,13 +861,13 @@ async def test_xfix_queries(members, m):
member1, member2, member3 = members

result = await m.Member.find(m.Member.first_name.startswith("And")).first()
assert result.first_name == "Andrew"
assert result.last_name == "Brookins"

result = await m.Member.find(m.Member.last_name.endswith("ins")).first()
assert result.first_name == "Andrew"
assert result.last_name == "Brookins"

result = await m.Member.find(m.Member.last_name.contains("ook")).first()
assert result.first_name == "Andrew"
assert result.last_name == "Brookins"

result = await m.Member.find(m.Member.bio % "great*").first()
assert result.first_name == "Andrew"
Expand Down
25 changes: 25 additions & 0 deletions tests/test_json_model.py
Original file line number Diff line number Diff line change
Expand Up @@ -1069,3 +1069,28 @@ class Example(JsonModel):

res = await Example.find(Example.d == ex.d and Example.b == True).first()
assert res.name == ex.name


@py_test_mark_asyncio
async def test_pagination():
class Test(JsonModel):
id: str = Field(primary_key=True, index=True)
num: int = Field(sortable=True, index=True)

@classmethod
async def get_page(cls, offset, limit):
return await cls.find().sort_by("num").page(limit=limit, offset=offset)

await Migrator().run()

pipe = Test.Meta.database.pipeline()
for i in range(0, 1000):
await Test(num=i, id=str(i)).save(pipeline=pipe)

await pipe.execute()
res = await Test.get_page(100, 100)
assert len(res) == 100
assert res[0].num == 100
res = await Test.get_page(10, 30)
assert len(res) == 30
assert res[0].num == 10
Loading