We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
message
LockError
Version: redis-py 5.0.2
Description: The newly-introduced __init__() on LockError required a message and fails without it.
__init__()
Previously, once could raise LockError() successfully. Making message a required positional argument fails existing code.
raise LockError()
Here's a simple mockup reproduction:
from redis.exceptions import LockError try: raise LockError() except LockError: print("LockError raised")
(obviously that's not real code, but demonstrates LockError with no message)
With the changes introduced in #3023 - specifically https://github.com/redis/redis-py/pull/3023/files#diff-38992dc598ce0eba5aba9cfd91541d9e61aaaf92387e88b5905685f7b3ffa129R85-R87
The same code raises:
TypeError: LockError.__init__() missing 1 required positional argument: 'message'
It's easy enough to fix on my end by adding a message, but it wasn't a backwards-compatible change and broke stuff.
The text was updated successfully, but these errors were encountered:
chore: add now-required message to LockError
bd83da0
Refs: redis/redis-py#3168 Signed-off-by: Mike Fiedler <miketheman@gmail.com>
Resolved by #3176
Sorry, something went wrong.
No branches or pull requests
Version: redis-py 5.0.2
Description: The newly-introduced
__init__()
onLockError
required amessage
and fails without it.Previously, once could
raise LockError()
successfully.Making
message
a required positional argument fails existing code.Here's a simple mockup reproduction:
(obviously that's not real code, but demonstrates
LockError
with no message)With the changes introduced in #3023 - specifically https://github.com/redis/redis-py/pull/3023/files#diff-38992dc598ce0eba5aba9cfd91541d9e61aaaf92387e88b5905685f7b3ffa129R85-R87
The same code raises:
It's easy enough to fix on my end by adding a
message
, but it wasn't a backwards-compatible change and broke stuff.The text was updated successfully, but these errors were encountered: