Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typing for address_remap is incorrect #3234

Closed
daveisfera opened this issue May 16, 2024 · 0 comments
Closed

Typing for address_remap is incorrect #3234

daveisfera opened this issue May 16, 2024 · 0 comments

Comments

@daveisfera
Copy link
Contributor

Version: 5.0.4

Platform: Python 3.12.3 on Debian Bookworm

Description: Typing for address_remap is as separate args but it's actually a tuple
daveisfera added a commit to daveisfera/redis-py that referenced this issue May 16, 2024
@daveisfera
Fix typing for address_remap (fixes redis#3234)
9343c0a
daveisfera added a commit to daveisfera/redis-py that referenced this issue May 16, 2024
@daveisfera
Fix typing for address_remap (fixes redis#3234)
e9d066e
daveisfera added a commit to daveisfera/redis-py that referenced this issue May 20, 2024
@daveisfera
Fix typing for address_remap (fixes redis#3234)
fc116ea
@gerzse gerzse closed this as completed in 9a70f62 May 21, 2024
gerzse pushed a commit to gerzse/redis-py that referenced this issue Jul 11, 2024
@daveisfera @gerzse
Fix typing for address_remap (fixes redis#3234) (redis#3235)
4498cab 
The address_remap callback received a tuple with the host and the port.
Make this clear in the typing hints.
gerzse pushed a commit that referenced this issue Jul 11, 2024
@daveisfera @gerzse
Fix typing for address_remap (fixes #3234) (#3235)
206d65b 
The address_remap callback received a tuple with the host and the port.
Make this clear in the typing hints.
vladvildanov pushed a commit that referenced this issue Sep 27, 2024
@daveisfera @vladvildanov
Fix typing for address_remap (fixes #3234) (#3235)
20eb71b 
The address_remap callback received a tuple with the host and the port.
Make this clear in the typing hints.
vladvildanov pushed a commit that referenced this issue Sep 27, 2024
@daveisfera @vladvildanov
Fix typing for address_remap (fixes #3234) (#3235)
ff944e1 
The address_remap callback received a tuple with the host and the port.
Make this clear in the typing hints.
vladvildanov pushed a commit that referenced this issue Sep 27, 2024
@daveisfera @vladvildanov
Fix typing for address_remap (fixes #3234) (#3235)
05ef930 
The address_remap callback received a tuple with the host and the port.
Make this clear in the typing hints.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@daveisfera