Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for COPY command new in Redis 6.2 #1492

Merged
merged 5 commits into from
Jul 20, 2021
Merged

Conversation

malinaa96
Copy link
Contributor

@malinaa96 malinaa96 commented Jun 12, 2021

Pull Request check-list

Please make sure to review and check all of these items:

  • Does $ tox pass with this change (including linting)?
  • Does travis tests pass with this change (enable it first in your forked repo and wait for the travis build to finish)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.

Description of change

Add support for COPY command available since Redis 6.2 as requested in #1434.

redis/client.py Outdated Show resolved Hide resolved
@chayim
Copy link
Contributor

chayim commented Jul 15, 2021

@malinaa96 Mind merging the latest master? Unit tests pass there, and we can see this all the way through - with your changes.

@chayim
Copy link
Contributor

chayim commented Jul 20, 2021

LGTM. Thanks @malinaa96 !

@chayim chayim merged commit 9ce7bb2 into redis:master Jul 20, 2021
chayim pushed a commit to chayim/redis-py that referenced this pull request Jul 25, 2021
Andrew-Chen-Wang added a commit to aio-libs-abandoned/aioredis-py that referenced this pull request Oct 8, 2021
Add support for COPY command new in Redis 6.2 (redis/redis-py#1492)

Signed-off-by: Andrew-Chen-Wang <acwangpython@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants