Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NOMKSTREAM support for XADD #1507

Merged
merged 2 commits into from
Jul 25, 2021
Merged

NOMKSTREAM support for XADD #1507

merged 2 commits into from
Jul 25, 2021

Conversation

chayim
Copy link
Contributor

@chayim chayim commented Jul 14, 2021

Part of #1434

Pending unit test fix pr

Pull Request check-list

Please make sure to review and check all of these items:

  • Does $ tox pass with this change (including linting)?
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.

Description of change

Adds NOMKSTREAM support to xadd.

@chayim chayim requested a review from andymccurdy July 15, 2021 07:16
Copy link
Contributor

@abrookins abrookins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@chayim chayim merged commit 57cf7ff into redis:master Jul 25, 2021
@chayim chayim deleted the ck-nomkstream-xadd branch July 25, 2021 06:03
chayim added a commit to chayim/redis-py that referenced this pull request Jul 25, 2021
chayim added a commit to chayim/redis-py that referenced this pull request Jul 29, 2021
Andrew-Chen-Wang added a commit to aio-libs-abandoned/aioredis-py that referenced this pull request Oct 8, 2021
NOMKSTREAM support for XADD (redis/redis-py#1507)

Signed-off-by: Andrew-Chen-Wang <acwangpython@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants