Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

getex #1515

Merged
merged 3 commits into from
Jul 22, 2021
Merged

getex #1515

merged 3 commits into from
Jul 22, 2021

Conversation

AvitalFineRedis
Copy link
Contributor

@AvitalFineRedis AvitalFineRedis commented Jul 21, 2021 •
edited
Loading

Pull Request check-list

Please make sure to review and check all of these items:

  • Does $ tox pass with this change (including linting)?
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.

Description of change

Add support to GETEX

@AvitalFineRedis
Copy link
Contributor Author

@chayim

chayim
chayim reviewed Jul 22, 2021
View reviewed changes
redis/client.py Outdated Show resolved Hide resolved
chayim
chayim reviewed Jul 22, 2021
View reviewed changes
redis/client.py Outdated Show resolved Hide resolved
chayim
chayim reviewed Jul 22, 2021
View reviewed changes
tests/test_commands.py Outdated Show resolved Hide resolved
@AvitalFineRedis
Copy link
Contributor Author

@chayim

@chayim
Copy link
Contributor

chayim commented Jul 22, 2021

Thanks for your contirbution!

@chayim chayim merged commit 3c244af into redis:master Jul 22, 2021
chayim pushed a commit to chayim/redis-py that referenced this pull request Jul 25, 2021
@AvitalFineRedis @chayim
getex (redis#1515)
98d0c30 
* getex

* flake8 fix

* comments
Andrew-Chen-Wang added a commit to aio-libs-abandoned/aioredis-py that referenced this pull request Oct 8, 2021
@Andrew-Chen-Wang
Add redis/redis-py@3c244af
a389184 
getex (redis/redis-py#1515)

* Removed small doc saying all time parameters can be datetime.timedelta. This is not needed with typing and can also be confusing with PXAT and EXAT

Signed-off-by: Andrew-Chen-Wang <acwangpython@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chayim chayim chayim left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AvitalFineRedis @chayim