Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add idle to xpending #1523

Merged
merged 7 commits into from
Aug 5, 2021
Merged

Conversation

AvitalFineRedis
Copy link
Contributor

@AvitalFineRedis AvitalFineRedis commented Jul 26, 2021

Pull Request check-list

Please make sure to review and check all of these items:

  • Does $ tox pass with this change (including linting)?
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.

Description of change

add IDLE option to XPENDING command

@AvitalFineRedis
Copy link
Contributor Author

@chayim

redis/client.py Outdated Show resolved Hide resolved
redis/client.py Outdated Show resolved Hide resolved
Copy link
Contributor

@chayim chayim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @AvitalFineRedis - take a look at the changes.

@AvitalFineRedis AvitalFineRedis requested a review from chayim July 29, 2021 08:50
@chayim chayim merged commit 9c60670 into redis:master Aug 5, 2021
Andrew-Chen-Wang added a commit to aio-libs-abandoned/aioredis-py that referenced this pull request Oct 8, 2021
add idle to xpending (redis/redis-py#1523)

Signed-off-by: Andrew-Chen-Wang <acwangpython@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants