-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement/test LOLWUT command #1568
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://redis.io/commands/lolwut This is a lot of fun to play with: ```python >>> from redis import Redis >>> redis = Redis() >>> print(redis.lolwut(5, 6, 7, 8).decode('utf-8')) ⣴⣶⣶⣶⣶⡆ ⣿⣿⣿⣿⣿⡇ ⠹⡿⠟⣿⡿⠃ ⠀⠀⠀⠀⠀⠀ Georg Nees - schotter, plotter on paper, 1968. Redis ver. 6.0.10 >>> print(redis.lolwut(5, 6, 7, 8).decode('utf-8')) ⢰⣶⣶⣶⣶⡆ ⢿⣿⣿⣿⣿⠁ ⠸⡿⢿⠿⡿⠃ ⠀⠀⠀⠀⠀⠀ Georg Nees - schotter, plotter on paper, 1968. Redis ver. 6.0.10 >>> print(redis.lolwut(5, 6, 7, 8).decode('utf-8')) ⢰⣶⣶⣶⣶⡆ ⣸⣿⣿⣻⣿⡅ ⠿⡿⠻⠿⠿⠁ ⠀⠀⠀⠀⠀⠀ Georg Nees - schotter, plotter on paper, 1968. Redis ver. 6.0.10 >>> ```
chayim
reviewed
Sep 5, 2021
chayim
reviewed
Sep 5, 2021
Co-authored-by: Chayim <chayim@users.noreply.github.com>
@chayim -- I believe I've addressed your feedback. 😅 How does this PR look now? |
66 tasks
The `LOLWUT` command was introduced in Redis 5.0.0: https://redis.io/commands/lolwut
@chayim - Good call. I've decorated the unit test to be skipped for Redis < 5.0.0. |
Amazing. Thanks again. Let's merge this in! |
brainix
added a commit
to brainix/pottery
that referenced
this pull request
Oct 1, 2021
I got `Redis.lolwut()` merged upstream! redis/redis-py#1568
brainix
added a commit
to brainix/pottery
that referenced
this pull request
Oct 1, 2021
* Delete the Redis.lolwut() monkey patch I got `Redis.lolwut()` merged upstream! redis/redis-py#1568 * Bump version number
Andrew-Chen-Wang
added a commit
to aio-libs-abandoned/aioredis-py
that referenced
this pull request
Oct 8, 2021
Implement/test LOLWUT command (redis/redis-py#1568) Signed-off-by: Andrew-Chen-Wang <acwangpython@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request check-list
$ tox
pass with this change (including linting)?Description of change
Implement/test
LOLWUT
commandThis is a lot of fun to play with: