Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Oxford comma properly in getex #1586

Merged
merged 1 commit into from
Oct 5, 2021
Merged

Conversation

Andrew-Chen-Wang
Copy link
Contributor

Pull Request check-list

Please make sure to review and check all of these items:

  • Does $ tox pass with this change (including linting)?
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.

Description of change

I believe the original implementation was trying to use an Oxford comma in the exception.

@chayim
Copy link
Contributor

chayim commented Oct 5, 2021

Thanks again @Andrew-Chen-Wang you're absolutely right. Much obliged as always! Great stuff, I love that someone's looking at our docs.

@chayim chayim merged commit 9419f1d into redis:master Oct 5, 2021
@Andrew-Chen-Wang
Copy link
Contributor Author

@chayim definitely helps to have someone looking at it! Truthfully though, I'm simply working on updating aioredis to match with redis-py. Also I'm not sure if this is too much to ask for, but do you mind adding hacktoberfest-accepted to some of these PRs? If it's too much of a burden, totally understand (seems like it was never done in the past here).

@Andrew-Chen-Wang Andrew-Chen-Wang deleted the patch-3 branch October 5, 2021 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants