Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix grammar of get param in set command #1588

Merged
merged 2 commits into from
Oct 18, 2021
Merged

Conversation

Andrew-Chen-Wang
Copy link
Contributor

Pull Request check-list

Please make sure to review and check all of these items:

  • Does $ tox pass with this change (including linting)?
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.

Description of change

Just a mechanical error in the docs

@@ -1122,7 +1122,7 @@ def set(self, name, value,
(Available since Redis 6.0)

``get`` if True, set the value at key ``name`` to ``value`` and return
the old value stored at key, or None when key did not exist.
the old value stored at key, or None if key did not exist.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if the

Copy link
Contributor

@chayim chayim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Andrew-Chen-Wang I love it - keep them coming! I think if the works better here. WDYT?

@Andrew-Chen-Wang
Copy link
Contributor Author

@chayim agreed. LGTM!

@chayim chayim merged commit 46430c2 into redis:master Oct 18, 2021
@Andrew-Chen-Wang Andrew-Chen-Wang deleted the patch-4 branch October 20, 2021 03:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants