Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pre 6.2 redis should default to None for script flush #1641

Merged
merged 2 commits into from
Oct 25, 2021
Merged

Pre 6.2 redis should default to None for script flush #1641

merged 2 commits into from
Oct 25, 2021

Conversation

chayim
Copy link
Contributor

@chayim chayim commented Oct 25, 2021

closes #1639

@chayim chayim added the bug Bug label Oct 25, 2021
@chayim chayim merged commit 0ef4c07 into redis:master Oct 25, 2021
@chayim chayim deleted the ck-1639-flushfix branch October 25, 2021 10:41
bmerry
bmerry reviewed Oct 25, 2021
View reviewed changes
redis/commands.py

# Redis pre 6 had no sync_type.
if sync_type not in ["SYNC", "ASYNC", None]:
raise DataError("SCRIPT FLUSH defaults to SYNC in redis > 6.2, or "
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mean >=?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmerry bmerry bmerry left review comments

Assignees
No one assigned
Labels
bug Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

4.0.0b1 breaks script_flush on pre-6.2 server
2 participants
@chayim @bmerry