-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CI action to install package from commit hash (#1781) #1790
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1790 +/- ##
=======================================
Coverage 94.22% 94.22%
=======================================
Files 74 74
Lines 15681 15681
=======================================
Hits 14776 14776
Misses 905 905 Continue to review full report at Codecov.
|
@ashwani99 awesome - this reproduces #1784 perfectly. I'll see what I can do to fix that. |
My two cents, I think this should be done for every version of python supported |
@WisdomPill Now that we have this, I think it's fair. @ashwani99 mind trying to yank the python-version and add it to your matrix, in addition to updating the name for this test to reflect the matrix? Then, I think we have something amazing, test-wise. Also, if you prefer I can add this change directly to your PR. I'd never want to step on your toes. |
@chayim sure, I will add the support for all python versions 3.6+ |
@ashwani99 For what it's worth, this was alerady useful. I used it to validate #1792 our collaboration on the resulting change from #1784 |
Thanks @ashwani99! It has been such a pleasure. Merging as discussed in #1784 |
Pull Request check-list
Please make sure to review and check all of these items:
$ tox
pass with this change (including linting)?NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.
Description of change
pip install
the package from current commit source