-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to PEP 517 packaging using hatchling #2388
Conversation
af128aa
to
46965bb
Compare
e8e7837
to
ab8e9a7
Compare
Refs redis#1316 Refs redis#1649 Co-authored-by: Ofek Lev <ofekmeister@gmail.com>
With no clear winner in the packaging space (yet) - and the ongoing flux, I don't see redis-py moving from setup.py currently. As this changes, it too should change. But hatch, is yet another attempt at something, and we'll watch it as it gains steam. |
Hey! Do you have some heuristic in mind, so the next person doesn't waste their time?
I don't see much of that. The |
sadly to see this :(, |
Refs redis#1316 Refs redis#1649 Remake of redis#2388 Co-authored-by: Ofek Lev <ofekmeister@gmail.com> x
Refs redis#1316 Refs redis#1649 Remake of redis#2388 Co-authored-by: Ofek Lev <ofekmeister@gmail.com>
Refs redis#1316 Refs redis#1649 Remake of redis#2388 Co-authored-by: Ofek Lev <ofekmeister@gmail.com>
Refs redis#1316 Refs redis#1649 Remake of redis#2388 Co-authored-by: Ofek Lev <ofekmeister@gmail.com>
Refs redis#1316 Refs redis#1649 Remake of redis#2388 Co-authored-by: Ofek Lev <ofekmeister@gmail.com>
Refs redis#1316 Refs redis#1649 Remake of redis#2388 Co-authored-by: Ofek Lev <ofekmeister@gmail.com>
Refs redis#1316 Refs redis#1649 Remake of redis#2388 Co-authored-by: Ofek Lev <ofekmeister@gmail.com>
Refs redis#1316 Refs redis#1649 Remake of redis#2388 Co-authored-by: Ofek Lev <ofekmeister@gmail.com>
Refs redis#1316 Refs redis#1649 Remake of redis#2388 Co-authored-by: Ofek Lev <ofekmeister@gmail.com>
Refs redis#1316 Refs redis#1649 Remake of redis#2388 Co-authored-by: Ofek Lev <ofekmeister@gmail.com>
Refs redis#1316 Refs redis#1649 Remake of redis#2388 Co-authored-by: Ofek Lev <ofekmeister@gmail.com>
Refs redis#1316 Refs redis#1649 Remake of redis#2388 Co-authored-by: Ofek Lev <ofekmeister@gmail.com>
Pull Request check-list
Please make sure to review and check all of these items:
$ tox
pass with this change (including linting)?Description of change
This PR shifts redis-py from legacy
setup.py
packaging to PEP 517 compliant packaging usinghatchling
from PyPA.Essentially, this does what was discussed in #1658 but with the increasingly standard
hatchling
tool instead of poetry's idiosyncracies.Refs #1316 (which initially did this, with tools from that age)
Refs #1649 (which reverted that for no good reason)
I wasn't able to test all of these changes yet, but
python -m build
does create a working wheel with all modules included.