Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Sismember Returned Value to int #2634

Closed
wants to merge 3 commits into from

Conversation

shacharPash
Copy link
Contributor

Pull Request check-list

Please make sure to review and check all of these items:

  • Does $ tox pass with this change (including linting)?
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Is there an example added to the examples folder (if applicable)?
  • Was the change added to CHANGES file?

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.

Description of change

Please provide a description of the change here.
Fixes #2622

@shacharPash shacharPash added breakingchange API or Breaking Change redis-py-5 redis-py 5 labels Mar 21, 2023
@shacharPash shacharPash requested review from chayim and dvora-h March 21, 2023 14:03
@codecov-commenter
Copy link

codecov-commenter commented Mar 21, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.02 ⚠️

Comparison is base (d95d8a2) 92.26% compared to head (d4b7afc) 92.24%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2634      +/-   ##
==========================================
- Coverage   92.26%   92.24%   -0.02%     
==========================================
  Files         116      116              
  Lines       30217    30217              
==========================================
- Hits        27879    27873       -6     
- Misses       2338     2344       +6     
Impacted Files Coverage Δ
redis/client.py 89.60% <ø> (ø)
redis/commands/core.py 82.04% <100.00%> (ø)

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@chayim
Copy link
Contributor

chayim commented Jun 8, 2023

@dvora-h for 5.x?

redis/commands/core.py Show resolved Hide resolved
@dvora-h dvora-h changed the base branch from master to 5.0 June 27, 2023 06:43
@dvora-h dvora-h changed the base branch from 5.0 to master June 27, 2023 06:44
@dvora-h dvora-h mentioned this pull request Jun 27, 2023
6 tasks
@chayim
Copy link
Contributor

chayim commented Jun 27, 2023

closed by #2813

@chayim chayim closed this Jun 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breakingchange API or Breaking Change docs-review redis-py-5 redis-py 5
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sismember and smismemeber have inconsistent returns
5 participants