Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support for triggered functions (TFUNCTION) #2861

Merged
merged 27 commits into from
Aug 8, 2023
Merged

Conversation

shacharPash
Copy link
Contributor

Pull Request check-list

Please make sure to review and check all of these items:

  • Does $ tox pass with this change (including linting)?
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Is there an example added to the examples folder (if applicable)?
  • Was the change added to CHANGES file?

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.

Description of change

Please provide a description of the change here.

@codecov-commenter
Copy link

codecov-commenter commented Jul 23, 2023

Codecov Report

Patch coverage: 94.16% and no project coverage change.

Comparison is base (8370c4a) 90.97% compared to head (ce50b83) 90.98%.
Report is 4 commits behind head on master.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@           Coverage Diff            @@
##           master    #2861    +/-   ##
========================================
  Coverage   90.97%   90.98%            
========================================
  Files         126      126            
  Lines       32178    32298   +120     
========================================
+ Hits        29273    29385   +112     
- Misses       2905     2913     +8     
Files Changed Coverage Δ
redis/cluster.py 92.70% <ø> (ø)
redis/commands/core.py 87.12% <81.57%> (-0.12%) ⬇️
redis/commands/cluster.py 93.08% <100.00%> (+0.07%) ⬆️
tests/test_cluster.py 97.44% <100.00%> (+0.05%) ⬆️
tests/test_commands.py 97.39% <100.00%> (+0.03%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shacharPash shacharPash added the feature New feature label Aug 1, 2023
redis/commands/core.py Outdated Show resolved Hide resolved
redis/commands/core.py Outdated Show resolved Hide resolved
redis/commands/core.py Outdated Show resolved Hide resolved
redis/commands/core.py Outdated Show resolved Hide resolved
redis/commands/core.py Outdated Show resolved Hide resolved
redis/commands/core.py Outdated Show resolved Hide resolved
redis/commands/core.py Outdated Show resolved Hide resolved
redis/commands/core.py Outdated Show resolved Hide resolved
redis/commands/core.py Outdated Show resolved Hide resolved
redis/commands/core.py Outdated Show resolved Hide resolved
redis/commands/core.py Outdated Show resolved Hide resolved
Copy link
Contributor

@chayim chayim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shacharPash @dvora-h @uglide any other comments?

@shacharPash shacharPash requested a review from chayim August 1, 2023 12:32
@shacharPash shacharPash marked this pull request as ready for review August 3, 2023 12:04
@chayim chayim changed the title Support RedisGears Commands Adding support for triggered functions (TFUNCTION) Aug 8, 2023
@chayim chayim merged commit d5c2d1d into master Aug 8, 2023
51 of 54 checks passed
@chayim chayim deleted the SupportGearsCommands branch August 8, 2023 11:06
@dvora-h dvora-h mentioned this pull request Sep 19, 2023
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants