Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redis.from_url returns Redis, not None #2975

Conversation

martimors
Copy link

Pull Request check-list

Please make sure to review and check all of these items:

  • Do tests and lints pass with this change?
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Is there an example added to the examples folder (if applicable)?
  • Was the change added to CHANGES file?

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.

Description of change

Pyright picked up this issue. Looks like it was introduced in #2952 (otherwise an excellent and very welcome contribution). No functional changes, just metadata.

@chayim chayim added maintenance Maintenance (CI, Releases, etc) bug Bug and removed maintenance Maintenance (CI, Releases, etc) labels Oct 5, 2023
@dvora-h
Copy link
Collaborator

dvora-h commented Oct 9, 2023

Fixed in #2963

@dvora-h dvora-h closed this Oct 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants