Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor how asyncio.BlockingConnectionPool gets connection. #2998

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kristjanvalur
Copy link
Contributor

Pull Request check-list

Please make sure to review and check all of these items:

  • Do tests and lints pass with this change?
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Is there an example added to the examples folder (if applicable)?
  • Was the change added to CHANGES file?

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.

Description of change

This is an update to previously merged pr #2997
We use inheritance to simplify the logic, the BlockingConnectionPool only needs to override get_available_connection()

@kristjanvalur kristjanvalur force-pushed the kristjan/BlockingConnectionPool-refactor branch 4 times, most recently from 48eb0b4 to 2ddc29b Compare October 11, 2023 15:29
@kristjanvalur kristjanvalur force-pushed the kristjan/BlockingConnectionPool-refactor branch from 2ddc29b to b886731 Compare October 11, 2023 15:44
@codecov-commenter
Copy link

codecov-commenter commented Oct 11, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (5391c5f) 91.36% compared to head (b886731) 91.37%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2998   +/-   ##
=======================================
  Coverage   91.36%   91.37%           
=======================================
  Files         126      126           
  Lines       32617    32611    -6     
=======================================
- Hits        29801    29798    -3     
+ Misses       2816     2813    -3     
Files Coverage Δ
redis/asyncio/connection.py 84.00% <100.00%> (+0.34%) ⬆️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants