Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Streamline documentation style #3232

Merged
merged 2 commits into from
May 15, 2024
Merged

Conversation

gerzse
Copy link
Contributor

@gerzse gerzse commented May 15, 2024

Pull Request check-list

Please make sure to review and check all of these items:

  • Do tests and lints pass with this change?
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Is there an example added to the examples folder (if applicable)?
  • Was the change added to CHANGES file?

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.

Description of change

Adopt the Google docstrings style as the preferred way to document code. Update one of the existing docstrings to the new format, to showcase how it would look like.

Enable the napoleon preprocessor in Sphinx, to be able to process Google style docstrings.

Take the opportunity to make the copyright year dynamic, so we don't have to manually keep it up to date.

Add a section about documentation to the contributors guide.

Adopt the Google docstrings style as the preferred way to document code.
Update one of the existing docstrings to the new format, to showcase how
it would look like.

Enable the `napoleon` preprocessor in Sphinx, to be able to process
Google style docstrings.

Take the opportunity to make the copyright year dynamic, so we don't
have to manually keep it up to date.

Add a section about documentation to the contributors guide.
@gerzse gerzse requested review from tishun and andy-stark-redis May 15, 2024 09:06
Copy link
Contributor

@andy-stark-redis andy-stark-redis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exactly what we were looking for, thanks!

@gerzse gerzse merged commit 6751de2 into redis:master May 15, 2024
46 checks passed
@gerzse gerzse added the maintenance Maintenance (CI, Releases, etc) label Jun 6, 2024
gerzse added a commit to gerzse/redis-py that referenced this pull request Jul 11, 2024
Adopt the Google docstrings style as the preferred way to document code.
Update one of the existing docstrings to the new format, to showcase how
it would look like.

Enable the `napoleon` preprocessor in Sphinx, to be able to process
Google style docstrings.

Take the opportunity to make the copyright year dynamic, so we don't
have to manually keep it up to date.

---------

Co-authored-by: Gabriel Erzse <gabriel.erzse@redis.com>
gerzse added a commit that referenced this pull request Jul 11, 2024
Adopt the Google docstrings style as the preferred way to document code.
Update one of the existing docstrings to the new format, to showcase how
it would look like.

Enable the `napoleon` preprocessor in Sphinx, to be able to process
Google style docstrings.

Take the opportunity to make the copyright year dynamic, so we don't
have to manually keep it up to date.

---------

Co-authored-by: Gabriel Erzse <gabriel.erzse@redis.com>
vladvildanov pushed a commit that referenced this pull request Sep 27, 2024
Adopt the Google docstrings style as the preferred way to document code.
Update one of the existing docstrings to the new format, to showcase how
it would look like.

Enable the `napoleon` preprocessor in Sphinx, to be able to process
Google style docstrings.

Take the opportunity to make the copyright year dynamic, so we don't
have to manually keep it up to date.

Add a section about documentation to the contributors guide.

---------

Co-authored-by: Gabriel Erzse <gabriel.erzse@redis.com>
vladvildanov pushed a commit that referenced this pull request Sep 27, 2024
Adopt the Google docstrings style as the preferred way to document code.
Update one of the existing docstrings to the new format, to showcase how
it would look like.

Enable the `napoleon` preprocessor in Sphinx, to be able to process
Google style docstrings.

Take the opportunity to make the copyright year dynamic, so we don't
have to manually keep it up to date.

Add a section about documentation to the contributors guide.

---------

Co-authored-by: Gabriel Erzse <gabriel.erzse@redis.com>
vladvildanov pushed a commit that referenced this pull request Sep 27, 2024
Adopt the Google docstrings style as the preferred way to document code.
Update one of the existing docstrings to the new format, to showcase how
it would look like.

Enable the `napoleon` preprocessor in Sphinx, to be able to process
Google style docstrings.

Take the opportunity to make the copyright year dynamic, so we don't
have to manually keep it up to date.

Add a section about documentation to the contributors guide.

---------

Co-authored-by: Gabriel Erzse <gabriel.erzse@redis.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Maintenance (CI, Releases, etc) update-docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants