Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parse FT.PROFILE response more robustly #3245

Merged
merged 1 commit into from
May 24, 2024
Merged

Parse FT.PROFILE response more robustly #3245

merged 1 commit into from
May 24, 2024

Conversation

gerzse
Copy link
Contributor

@gerzse gerzse commented May 24, 2024

Pull Request check-list

Please make sure to review and check all of these items:

  • Do tests and lints pass with this change?
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Is there an example added to the examples folder (if applicable)?
  • Was the change added to CHANGES file?

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.

Description of change

When parsing the response of FT.PROFILE, handle the cases when the nested items are either not lists, or empty lists, or lists with a single item.

@gerzse
Parse FT.PROFILE response more robustly
349f78b 
When parsing the response of FT.PROFILE, handle the cases when the
nested items are either not lists, or empty lists, or lists with a
single item.
@gerzse gerzse requested a review from vladvildanov May 24, 2024 07:25
@gerzse gerzse added the maintenance Maintenance (CI, Releases, etc) label May 24, 2024
@gerzse gerzse merged commit b7a85eb into redis:master May 24, 2024
47 checks passed
gerzse added a commit to gerzse/redis-py that referenced this pull request Jun 13, 2024
@gerzse
Parse FT.PROFILE response more robustly (redis#3245)
3389075 
When parsing the response of FT.PROFILE, handle the cases when the
nested items are either not lists, or empty lists, or lists with a
single item.

Co-authored-by: Gabriel Erzse <gabriel.erzse@redis.com>
vladvildanov pushed a commit that referenced this pull request Sep 27, 2024
@gerzse @vladvildanov
Parse FT.PROFILE response more robustly (#3245)
443a9cc 
When parsing the response of FT.PROFILE, handle the cases when the
nested items are either not lists, or empty lists, or lists with a
single item.

Co-authored-by: Gabriel Erzse <gabriel.erzse@redis.com>
vladvildanov pushed a commit that referenced this pull request Sep 27, 2024
@gerzse @vladvildanov
Parse FT.PROFILE response more robustly (#3245)
bce46f4 
When parsing the response of FT.PROFILE, handle the cases when the
nested items are either not lists, or empty lists, or lists with a
single item.

Co-authored-by: Gabriel Erzse <gabriel.erzse@redis.com>
vladvildanov pushed a commit that referenced this pull request Sep 27, 2024
@gerzse @vladvildanov
Parse FT.PROFILE response more robustly (#3245)
60e88cf 
When parsing the response of FT.PROFILE, handle the cases when the
nested items are either not lists, or empty lists, or lists with a
single item.

Co-authored-by: Gabriel Erzse <gabriel.erzse@redis.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vladvildanov vladvildanov vladvildanov approved these changes

Assignees
No one assigned
Labels
maintenance Maintenance (CI, Releases, etc)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gerzse @vladvildanov