Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test special characters escaping in search #3276

Merged
merged 2 commits into from
Jun 13, 2024
Merged

Test special characters escaping in search #3276

merged 2 commits into from
Jun 13, 2024

Conversation

gerzse
Copy link
Contributor

@gerzse gerzse commented Jun 13, 2024

Pull Request check-list

Please make sure to review and check all of these items:

  • Do tests and lints pass with this change?
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Is there an example added to the examples folder (if applicable)?
  • Was the change added to CHANGES file?

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.

Description of change

With RediSearch dialect 5 less special characters need escaping when searching, given that TAG fields are used. Add a test to show some examples.

@gerzse
Test special characters escaping in search
2c9df43 
With RediSearch dialect 5 less special characters need escaping when
searching, given that TAG fields are used. Add a test to show some
examples.
@gerzse gerzse added the maintenance Maintenance (CI, Releases, etc) label Jun 13, 2024
@gerzse gerzse requested a review from vladvildanov June 13, 2024 08:26
@gerzse gerzse merged commit 6de9696 into redis:master Jun 13, 2024
47 checks passed
gerzse added a commit to gerzse/redis-py that referenced this pull request Jul 11, 2024
@gerzse
Test special characters escaping in search (redis#3276)
0785f81 
With RediSearch dialect 5 less special characters need escaping when
searching, given that TAG fields are used. Add a test to show some
examples.
gerzse added a commit that referenced this pull request Jul 11, 2024
@gerzse
Test special characters escaping in search (#3276)
335adc2 
With RediSearch dialect 5 less special characters need escaping when
searching, given that TAG fields are used. Add a test to show some
examples.
agnesnatasya pushed a commit to agnesnatasya/redis-py that referenced this pull request Jul 20, 2024
@gerzse @agnesnatasya
Test special characters escaping in search (redis#3276)
4b68646 
With RediSearch dialect 5 less special characters need escaping when
searching, given that TAG fields are used. Add a test to show some
examples.
vladvildanov pushed a commit that referenced this pull request Sep 27, 2024
@gerzse @vladvildanov
Test special characters escaping in search (#3276)
b402648 
With RediSearch dialect 5 less special characters need escaping when
searching, given that TAG fields are used. Add a test to show some
examples.
vladvildanov pushed a commit that referenced this pull request Sep 27, 2024
@gerzse @vladvildanov
Test special characters escaping in search (#3276)
168f6e5 
With RediSearch dialect 5 less special characters need escaping when
searching, given that TAG fields are used. Add a test to show some
examples.
vladvildanov pushed a commit that referenced this pull request Sep 27, 2024
@gerzse @vladvildanov
Test special characters escaping in search (#3276)
c7ccba9 
With RediSearch dialect 5 less special characters need escaping when
searching, given that TAG fields are used. Add a test to show some
examples.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vladvildanov vladvildanov vladvildanov approved these changes

Assignees
No one assigned
Labels
maintenance Maintenance (CI, Releases, etc)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gerzse @vladvildanov