-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve parsing of XINFO STREAM response #3282
Conversation
This is a tiny fix, I can add test cases and changelogs for this if needed |
Thanks @Wh1isper It would be great if you can add tests, one with a response before XTRIM, one for a response after XTRIM. |
@gerzse I've added test code for this change on the original CI: https://github.com/Wh1isper/redis-py/actions/runs/9544241170 |
Thanks for the tests @Wh1isper |
Make the parsing of XINFO STREAM response more resilient, by handling the case when first and last entries are None after XTRIM. Improve the parsing of consumers related info.
Make the parsing of XINFO STREAM response more resilient, by handling the case when first and last entries are None after XTRIM. Improve the parsing of consumers related info.
Make the parsing of XINFO STREAM response more resilient, by handling the case when first and last entries are None after XTRIM. Improve the parsing of consumers related info.
Make the parsing of XINFO STREAM response more resilient, by handling the case when first and last entries are None after XTRIM. Improve the parsing of consumers related info.
Make the parsing of XINFO STREAM response more resilient, by handling the case when first and last entries are None after XTRIM. Improve the parsing of consumers related info.
Make the parsing of XINFO STREAM response more resilient, by handling the case when first and last entries are None after XTRIM. Improve the parsing of consumers related info.
Pull Request check-list
Please make sure to review and check all of these items:
NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.
Description of change
Please provide a description of the change here.
closes: #3065
And also fix when there is no group(
data["groups"] == []
) and parseconsumer
by defualt