Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suppress Graph deprecation warning in test suite #3316

Merged

Conversation

kurtmckee
Copy link
Contributor

Pull Request check-list

Please make sure to review and check all of these items:

  • Do tests and lints pass with this change?
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Is there an example added to the examples folder (if applicable)?
  • Was the change added to CHANGES file?

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.

Description of change

When the test suite runs in CI, it shows that there are many uncaught DeprecationWarning messages (recent example).

These occur when Graph is instantiated and are expected. Therefore, they should be ignored by default, so other issues can be focused on.

This PR introduces the following changes:

  • The pytest warnings configuration (currently present as the CLI argument -W always) is moved to pytest.ini
  • The specific DeprecationWarning is now ignored by default in pytest.ini
  • A new test was added to ensure that the DeprecationWarning is actually being thrown when Graph is instantiated.

If this merges, it will reduce the warning output that pytest displays after running the test suite.

One extra test is added to verify the warning is actually thrown.
@gerzse gerzse added the maintenance Maintenance (CI, Releases, etc) label Jul 17, 2024
@gerzse gerzse merged commit b206a0f into redis:master Jul 17, 2024
56 checks passed
@kurtmckee kurtmckee deleted the suppress-graph-deprecation-warning-in-test-suite branch July 17, 2024 11:22
vladvildanov pushed a commit that referenced this pull request Sep 27, 2024
Move pytest warning control to `pytest.ini`.

Ignore `Graph` `DeprecationWarning` in the test suite

One extra test is added to verify the warning is actually thrown.
vladvildanov pushed a commit that referenced this pull request Sep 27, 2024
Move pytest warning control to `pytest.ini`.

Ignore `Graph` `DeprecationWarning` in the test suite

One extra test is added to verify the warning is actually thrown.
vladvildanov pushed a commit that referenced this pull request Sep 27, 2024
Move pytest warning control to `pytest.ini`.

Ignore `Graph` `DeprecationWarning` in the test suite

One extra test is added to verify the warning is actually thrown.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Maintenance (CI, Releases, etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants