Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Flake8 #3323

Merged
merged 1 commit into from
Jul 18, 2024
Merged

Upgrade Flake8 #3323

merged 1 commit into from
Jul 18, 2024

Conversation

gerzse
Copy link
Contributor

@gerzse gerzse commented Jul 18, 2024

Pull Request check-list

Please make sure to review and check all of these items:

  • Do tests and lints pass with this change?
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Is there an example added to the examples folder (if applicable)?
  • Was the change added to CHANGES file?

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.

Description of change

Use the latest available Flake8. Fix some linter errors that surfaced.

Take the opportunity to fix typing hints and remove code duplication around CommandsProtocol.

Use the latest available Flake8. Fix some linter errors that surfaced.

Take the opportunity to fix typing hints and remove code duplication
around CommandsProtocol.
@gerzse gerzse added the maintenance Maintenance (CI, Releases, etc) label Jul 18, 2024
@gerzse gerzse requested a review from vladvildanov July 18, 2024 10:32
@gerzse gerzse merged commit 7e2b4fb into redis:master Jul 18, 2024
56 checks passed
vladvildanov pushed a commit that referenced this pull request Sep 27, 2024
Use the latest available Flake8. Fix some linter errors that surfaced.

Take the opportunity to fix typing hints and remove code duplication
around CommandsProtocol.
vladvildanov pushed a commit that referenced this pull request Sep 27, 2024
Use the latest available Flake8. Fix some linter errors that surfaced.

Take the opportunity to fix typing hints and remove code duplication
around CommandsProtocol.
vladvildanov pushed a commit that referenced this pull request Sep 27, 2024
Use the latest available Flake8. Fix some linter errors that surfaced.

Take the opportunity to fix typing hints and remove code duplication
around CommandsProtocol.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Maintenance (CI, Releases, etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants