Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added version restrictions for pytest-asyncio #3362

Merged
merged 1 commit into from
Sep 2, 2024

Conversation

vladvildanov
Copy link
Collaborator

Pull Request check-list

Please make sure to review and check all of these items:

  • Do tests and lints pass with this change?
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Is there an example added to the examples folder (if applicable)?
  • Was the change added to CHANGES file?

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.

Description of change

Please provide a description of the change here.

@akx
Copy link
Contributor

akx commented Aug 27, 2024

Since the PR description doesn't mention why this needs to be done: pytest-asyncio==0.24.0

Raises an error when passing scope or loop_scope as a positional argument to @pytest.mark.asyncio.

@vladvildanov vladvildanov merged commit 76bf989 into master Sep 2, 2024
56 checks passed
@vladvildanov vladvildanov deleted the vv-asyncio-restriction branch September 2, 2024 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants