Fix redis-clustering gem to pass the test with latest dependencies #1222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
supercaracal
commented
Sep 13, 2023
| @@ -28,11 +28,11 @@ def initialize(*) | |||
| ruby2_keywords :initialize if respond_to?(:ruby2_keywords, true) | |||
|
|
|||
| def id | |||
| @router.node.node_keys.join(' ') | |||
| @router.node_keys.join(' ') | |||
There was a problem hiding this comment.
supercaracal
commented
Sep 13, 2023
| @@ -47,5 +47,5 @@ Gem::Specification.new do |s| | |||
| s.required_ruby_version = '>= 2.7.0' | |||
|
|
|||
| s.add_runtime_dependency('redis', s.version) | |||
| s.add_runtime_dependency('redis-cluster-client', '>= 0.3.7') | |||
| s.add_runtime_dependency('redis-cluster-client', '>= 0.6.1') | |||
There was a problem hiding this comment.
supercaracal
commented
Sep 13, 2023
| @@ -47,7 +47,7 @@ def test_migrate | |||
| def test_object | |||
| redis.lpush('mylist', 'Hello World') | |||
| assert_equal 1, redis.object('refcount', 'mylist') | |||
| assert_equal 'quicklist', redis.object('encoding', 'mylist') | |||
| assert_equal 'listpack', redis.object('encoding', 'mylist') | |||
There was a problem hiding this comment.
It looks like internal changes for Redis 7.2.
There was a problem hiding this comment.
Yes, it's best to either remove that test or to allow both values.
There is no point testing Redis internal implementation.
supercaracal
commented
Sep 13, 2023
| expected << "multi-mem" << "rbp" << "rbs" << "resp" << "ssub" if version >= '7.0' | ||
| assert_equal expected.sort, actual.sort | ||
| assert_instance_of Hash, a_client_info | ||
| assert_includes a_client_info, 'addr' |
There was a problem hiding this comment.
- It looks like server side changes for reply type from Array to Hash.
- I simplified this test case rather than meticulous assertion because it is weak against server side minor changes.
supercaracal
force-pushed
the
fix-cluster
branch
from
9cb7583 to
ea4d04a
Compare
supercaracal
commented
Sep 13, 2023
| @@ -47,7 +47,6 @@ def test_migrate | |||
| def test_object | |||
| redis.lpush('mylist', 'Hello World') | |||
| assert_equal 1, redis.object('refcount', 'mylist') | |||
| assert_equal 'quicklist', redis.object('encoding', 'mylist') | |||
There was a problem hiding this comment.
It was changed to 'listpack' in Redis 7.2. We have no advantages for testing redis minor behavior, so just removed.
|
The CI job was failed but it was related to sentinel. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
0.6.1, redis-rb should adapt codes depended on it.