Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alias the disconnect method as close #901

Merged
merged 1 commit into from
May 1, 2020
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Implement close method
The connection_pool gem is implementing  automatic reaping of idle connections. In order to do this generically, clients need to provide a `close` method that the pool can call on reaped connections in order to close the network connection cleanly.

mysql2 and dalli already provide `close`. This PR adds this convention to redis-rb.
  • Loading branch information
mperham authored Apr 30, 2020
commit 55a910659665a0672f2f97067bc96d8fb6ee2dc1
1 change: 1 addition & 0 deletions lib/redis/client.rb
Original file line number Diff line number Diff line change
@@ -250,6 +250,7 @@ def connected?
def disconnect
connection.disconnect if connected?
end
alias_method :close, :disconnect

def reconnect
disconnect