Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redis connection refactor #104

Merged
merged 6 commits into from
Feb 1, 2024
Merged

Conversation

tylerhutcherson
Copy link
Collaborator

@tylerhutcherson tylerhutcherson commented Jan 31, 2024

For ultimate clarity and safety of our library, the decision was made to separate the sync and async search index modules for now until we can better utilize the redis-py client to serve both needs simultaneously.

This PR splits SearchIndex and AsyncSearchIndex into two classes. It also refactors the way RedisVL handles Redis connections (much more lightweight) and makes some major improvements to the overall documentation on these topics.

@codecov-commenter
Copy link

codecov-commenter commented Jan 31, 2024

Codecov Report

Attention: 47 lines in your changes are missing coverage. Please review.

Comparison is base (8a55e35) 77.32% compared to head (0583540) 78.90%.

Files Patch % Lines
redisvl/index.py 75.00% 32 Missing ⚠️
redisvl/redis/utils.py 65.38% 9 Missing ⚠️
redisvl/redis/connection.py 92.85% 3 Missing ⚠️
redisvl/schema/schema.py 40.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #104      +/-   ##
==========================================
+ Coverage   77.32%   78.90%   +1.57%     
==========================================
  Files          23       24       +1     
  Lines        1429     1474      +45     
==========================================
+ Hits         1105     1163      +58     
+ Misses        324      311      -13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tylerhutcherson tylerhutcherson added breakingchange breaking change to API enhancement New feature or request documentation Improvements or additions to documentation labels Jan 31, 2024
@tylerhutcherson tylerhutcherson marked this pull request as ready for review January 31, 2024 22:37
@tylerhutcherson tylerhutcherson force-pushed the redis-connection-refactor branch from 713e3d2 to 5d161b0 Compare February 1, 2024 04:55
@tylerhutcherson tylerhutcherson force-pushed the redis-connection-refactor branch from 5d161b0 to 56fe03b Compare February 1, 2024 05:01
@tylerhutcherson
Copy link
Collaborator Author

Will address the concerns from #88

@tylerhutcherson tylerhutcherson merged commit 4f120b0 into main Feb 1, 2024
18 checks passed
@tylerhutcherson tylerhutcherson deleted the redis-connection-refactor branch February 6, 2024 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breakingchange breaking change to API documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants