Poetry for Dependency Management and TestContainers for Integration Testing #134
+5,151
−288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tylerhutcherson Test will likely fail in CI since we would need to configure Github Actions correctly to use TestContainers. I will look into that soon. But please test locally and see if it all works for you! |
bsbodden
force-pushed
the
bsb/poetry-and-test-containers
branch
6 times, most recently
from
0a45659 to
a02257a
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #134 +/- ##
=======================================
Coverage 88.43% 88.43%
=======================================
Files 26 26
Lines 1565 1565
=======================================
Hits 1384 1384
Misses 181 181 ☔ View full report in Codecov by Sentry. |
bsbodden
force-pushed
the
bsb/poetry-and-test-containers
branch
6 times, most recently
from
8a82e13 to
74f709b
Compare
bsbodden
force-pushed
the
bsb/poetry-and-test-containers
branch
5 times, most recently
from
37edf15 to
c11e5d0
Compare
bsbodden
force-pushed
the
bsb/poetry-and-test-containers
branch
2 times, most recently
from
5bb2f7a to
bba1c44
Compare
bsbodden
commented
Apr 13, 2024
bsbodden
force-pushed
the
bsb/poetry-and-test-containers
branch
2 times, most recently
from
3169a8a to
4571aef
Compare
bsbodden
force-pushed
the
bsb/poetry-and-test-containers
branch
10 times, most recently
from
d0221d8 to
3283d38
Compare
bsbodden
force-pushed
the
bsb/poetry-and-test-containers
branch
from
3283d38 to
19e2af8
Compare
rbs333
reviewed
Apr 26, 2024
poetry check failing for unrecognized classifier
tylerhutcherson
force-pushed
the
bsb/poetry-and-test-containers
branch
from
c9c8758 to
0aa0ced
Compare
justin-cechmanek
pushed a commit
that referenced
this pull request
May 6, 2024
…esting (#134) In this PR: - Uses Poetry for Dependency Management - Replaces the Makefile with Python scripts that can be run from Poetry - Implements TestContainers with a Docker Compose file for integration testing --------- Co-authored-by: Robert Shelton <robert.b.shelton.42@gmail.com> Co-authored-by: Tyler Hutcherson <tyler.hutcherson@redis.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR: