-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Repackage documentation and apply poetry updates #146
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #146 +/- ##
=======================================
Coverage 88.60% 88.60%
=======================================
Files 29 29
Lines 1667 1667
=======================================
Hits 1477 1477
Misses 190 190 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM just left a small question on the html files numbering
docs/_static/js/sidebar.js
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any reason the numbers on the html pages are not in order - top to bottom?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no reason besides not wanting to commit thousands of lines to rename haha. They were initially ordered a certain way and the custom side bar was added to allow us to dynamically change the sidebar without re committing the files themselves essentially -- probably don't need numbers on the files tbh
docs/_static/site.webmanifest
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
new brand icons I assume?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Improves VL documentation with new Redis logos, poetry scripting, poetry docs dependencies, and also adds new reranking user guide.
Improves VL documentation with new Redis logos, poetry scripting, poetry docs dependencies, and also adds new reranking user guide.