Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support inorder query param #190

Merged
merged 2 commits into from
Jul 29, 2024

Conversation

tylerhutcherson
Copy link
Collaborator

No description provided.

@tylerhutcherson tylerhutcherson added the enhancement New feature or request label Jul 29, 2024
@justin-cechmanek
Copy link
Collaborator

More of a question, and not a critique: what are your opinions on defaulting to None for the in_order bool instead of False? Looks like the logic and behavior is identical either way.

@tylerhutcherson
Copy link
Collaborator Author

More of a question, and not a critique: what are your opinions on defaulting to None for the in_order bool instead of False? Looks like the logic and behavior is identical either way.

You're exactly right -- oversight by me. Updated it in the latest commit.

Copy link
Collaborator

@justin-cechmanek justin-cechmanek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tylerhutcherson tylerhutcherson merged commit 877f4f2 into main Jul 29, 2024
20 checks passed
@tylerhutcherson tylerhutcherson deleted the feat/RAAE-199/support-query-inorder branch July 29, 2024 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants