Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Amazon Bedrock Text vectorizer #248

Merged
merged 2 commits into from
Dec 2, 2024

Conversation

bsbodden
Copy link
Collaborator

@bsbodden bsbodden commented Nov 25, 2024

Add a Vectorizer for Amazon Bedrock, along with tests and doc updates.

@tylerhutcherson tylerhutcherson added the enhancement New feature or request label Nov 26, 2024
@tylerhutcherson tylerhutcherson changed the title Add Amazon Bedrock Text vectorizer (#143) Add Amazon Bedrock Text vectorizer Nov 26, 2024
Copy link
Collaborator

@tylerhutcherson tylerhutcherson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work. Left a few comments!

redisvl/utils/vectorize/text/bedrock.py Outdated Show resolved Hide resolved
redisvl/utils/vectorize/text/bedrock.py Show resolved Hide resolved
redisvl/utils/vectorize/text/bedrock.py Outdated Show resolved Hide resolved
@bsbodden bsbodden force-pushed the bsb/amazon_bedrock_text_vectorizer branch 2 times, most recently from 1da6f20 to b9bcc9d Compare November 27, 2024 23:33
@bsbodden bsbodden force-pushed the bsb/amazon_bedrock_text_vectorizer branch from b9bcc9d to 2e1b074 Compare November 27, 2024 23:39
Copy link
Collaborator

@tylerhutcherson tylerhutcherson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docs comment -- overall code looks great. Need tests to pass.

docs/api/vectorizer.rst Outdated Show resolved Hide resolved
docs/api/vectorizer.rst Outdated Show resolved Hide resolved
@bsbodden bsbodden force-pushed the bsb/amazon_bedrock_text_vectorizer branch 4 times, most recently from 1374da1 to 144a893 Compare December 2, 2024 20:49
@bsbodden bsbodden force-pushed the bsb/amazon_bedrock_text_vectorizer branch from 144a893 to 72c6ad2 Compare December 2, 2024 20:57
@tylerhutcherson tylerhutcherson self-requested a review December 2, 2024 21:45
Copy link
Collaborator

@tylerhutcherson tylerhutcherson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@tylerhutcherson tylerhutcherson merged commit 2ab5cb8 into main Dec 2, 2024
20 checks passed
@tylerhutcherson tylerhutcherson deleted the bsb/amazon_bedrock_text_vectorizer branch December 2, 2024 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants