Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating security contact email address #59

Merged
merged 1 commit into from
Sep 10, 2023
Merged

Conversation

chayim
Copy link
Contributor

@chayim chayim commented Aug 30, 2023

Aligning with various other redis projects, by updating the designated security contact.

Copy link
Contributor

@Spartee Spartee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Spartee
Copy link
Contributor

Spartee commented Sep 5, 2023

@chayim this seems to be failing on API keys from Openai.. not sure why?

@chayim
Copy link
Contributor Author

chayim commented Sep 5, 2023

Looks like authentication failure. I don't have repo perms to see what secrets are defined. I see a secrets.OPENAI_KEY in GH actions - and in the codebase.. what happens when you run locally? Clearly these aren't related (and IMHO merge away)

ERROR tests/integration/test_vectorizers.py::test_vectorizer_embed_many[OpenAITextVectorizer] - ValueError: Error authenticating with the OpenAI API: You didn't provide an API key. You need to provide your API key in an Authorization header using *** (i.e. Authorization: *** or as the password field (with blank username) if you're accessing the API from your browser and are prompted for a username and password. You can obtain an API key from

@chayim chayim merged commit cf630f0 into redis:main Sep 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants