Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for token escaper class #69

Merged
merged 5 commits into from
Oct 20, 2023
Merged

Add tests for token escaper class #69

merged 5 commits into from
Oct 20, 2023

Conversation

tylerhutcherson
Copy link
Collaborator

Adds a set of unit tests on both the underlying token escaping class as well as the Tag filterable fields that utilize it.

@tylerhutcherson tylerhutcherson changed the title Test tokenizer Add tests for token escaper class Oct 18, 2023
@codecov-commenter
Copy link

codecov-commenter commented Oct 18, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (4aab8b7) 87.12% compared to head (234bf8d) 87.43%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #69      +/-   ##
==========================================
+ Coverage   87.12%   87.43%   +0.30%     
==========================================
  Files          16       17       +1     
  Lines         870      899      +29     
==========================================
+ Hits          758      786      +28     
- Misses        112      113       +1     
Files Coverage Δ
redisvl/query/filter.py 90.79% <100.00%> (ø)
redisvl/utils/utils.py 90.00% <100.00%> (+3.46%) ⬆️
redisvl/utils/token_escaper.py 93.33% <93.33%> (ø)

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@Spartee Spartee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some test names, but otherwise looks great!

@Spartee Spartee merged commit 4e3de2d into main Oct 20, 2023
@Spartee Spartee deleted the test-tokenizer branch October 20, 2023 23:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants