Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom multidex and custom flutter packer #372

Merged

Conversation

ReBensk
Copy link
Contributor

@ReBensk ReBensk commented Oct 24, 2023

Reference ticket id:
#368
#370

{
meta:
description = "custom_flutter"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The description tag you can maintain the previous name "Custom Flutter"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maintained the previous name "Custom Flutter"

Copy link
Collaborator

@enovella enovella Oct 25, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This

rule custom_flutter : packer 
{ 
 meta:
	description = "custom_flutter"
...
}

should be

rule custom_flutter : packer 
{ 
 meta:
	description = "Custom Flutter"
...
}

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I cannot see this fixed @ReBensk

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please address this

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last change before merging in master. Please address this

@enovella
Copy link
Collaborator

Hi @ReBensk ,

Almost there! I have noticed that this file and others in the project are using 2 spaces. Check other rules within the file you're pushing into. Please remove the extra indentation, and we'd be able to finally merge it. Good work and thanks!

@ReBensk
Copy link
Contributor Author

ReBensk commented Oct 24, 2023

Hi @enovella,

I have removed the extra indentation. “Thank you for your valuable feedback”

Copy link
Collaborator

@enovella enovella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I cannot see the last changes applied on the PR. Did you manage to push the changes in #372 ?

@ReBensk
Copy link
Contributor Author

ReBensk commented Oct 25, 2023

I cannot see the last changes applied on the PR. Did you manage to push the changes in #372 ?
"Now it's fixed"

author = "ReBensk"
{
meta:
description = "custom_flutter"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't forget "Custom Flutter" :P

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ReBensk
Copy link
Contributor Author

ReBensk commented Oct 26, 2023

Did some small changes on the code to cover more samples

@enovella enovella self-requested a review October 26, 2023 14:17
@enovella enovella self-assigned this Oct 26, 2023
@ReBensk
Copy link
Contributor Author

ReBensk commented Oct 26, 2023

"Custom Flutter" instead of "description: custom_flutter" and "Custom Multidex" instead of description = "Custom multidex"

@enovella
Copy link
Collaborator

Hi @ReBensk ,

Unfortunately, I didn't have the time to review well the opcodes and so on. Let's merge it and see if you can tweak it more in the near future. Thanks for your work.

Edu

@enovella enovella merged commit 0546b06 into rednaga:master Oct 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants