Custom multidex and custom flutter packer #372
Conversation
Update packers.yara
Modified CustomMultiDexPacker to detect more samples
Reference ticket id: rednaga#368 rednaga#370
apkid/rules/dex/packers.yara
Outdated
| { | ||
| meta: | ||
| description = "custom_flutter" |
There was a problem hiding this comment.
The description tag you can maintain the previous name "Custom Flutter"
There was a problem hiding this comment.
maintained the previous name "Custom Flutter"
There was a problem hiding this comment.
This
rule custom_flutter : packer
{
meta:
description = "custom_flutter"
...
}should be
rule custom_flutter : packer
{
meta:
description = "Custom Flutter"
...
}There was a problem hiding this comment.
I cannot see this fixed @ReBensk
There was a problem hiding this comment.
Last change before merging in master. Please address this
|
Hi @ReBensk , Almost there! I have noticed that this file and others in the project are using 2 spaces. Check other rules within the file you're pushing into. Please remove the extra indentation, and we'd be able to finally merge it. Good work and thanks! |
|
Hi @enovella, I have removed the extra indentation. “Thank you for your valuable feedback” |
|
apkid/rules/dex/packers.yara
Outdated
| author = "ReBensk" | ||
| { | ||
| meta: | ||
| description = "custom_flutter" |
There was a problem hiding this comment.
Don't forget "Custom Flutter" :P
|
Did some small changes on the code to cover more samples |
|
"Custom Flutter" instead of "description: custom_flutter" and "Custom Multidex" instead of description = "Custom multidex" |
|
Hi @ReBensk , Unfortunately, I didn't have the time to review well the opcodes and so on. Let's merge it and see if you can tweak it more in the near future. Thanks for your work. Edu |
Reference ticket id:
#368
#370