Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

npm command in watch.js run() function throws error in Windows. #4

Closed
whindes opened this issue Sep 12, 2017 · 3 comments
Closed

npm command in watch.js run() function throws error in Windows. #4

whindes opened this issue Sep 12, 2017 · 3 comments

Comments

@whindes
Copy link

whindes commented Sep 12, 2017

In review of this wonderful framework library (big thanks!), I discovered a potential issue running in Windows 7.

assets/watch.js

function run (cmd, forever) {
//const child = cp.spawn('npm', ['run', cmd]);
//Workaround
const child = cp.spawn('npm.cmd', ['run', cmd]);

child.stdout.pipe(process.stdout);
child.stderr.pipe(process.stderr);

if (forever) {
child.on('exit', () => {
setTimeout(run, 5000, cmd, true);
});
}

return child;
}

pakastin added a commit that referenced this issue Dec 5, 2017
@pakastin
Copy link
Member

pakastin commented Dec 5, 2017

Sorry, for some reason I've missed this issue. Fixing now..

@pakastin
Copy link
Member

pakastin commented Dec 5, 2017

@pakastin pakastin closed this as completed Dec 5, 2017
@pakastin
Copy link
Member

pakastin commented Dec 5, 2017

Thanks for letting know about this and hope you like RE:DOM! 😎👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants