Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Version 1.0 rewrite #22

Closed

Conversation

ChristianMurphy
Copy link
Member

@ChristianMurphy ChristianMurphy commented Jul 31, 2021

This is a ground up rewrite of much of the codebase, some major changes that are part of this:

What's still the same:

TODO:

  • update build system
  • rewrite redot-parse
  • test redot-parse
  • rewrite redot-stringify
  • test redot-stringify
  • rewrite redot
  • test redot
  • rewrite redot-cli
  • update documentation with ESM

@ChristianMurphy ChristianMurphy added 🗄 area/interface This affects the public interface 🕸️ area/tests This affects tests 🏗 area/tools This affects tooling ☂️ area/types This affects typings 🛠 blocked/wip This cannot progress yet, it’s being worked on 🧑 semver/major This is a change labels Jul 31, 2021
@kamiazya
Copy link

@ChristianMurphy @wooorm

Hi,

This project is designed to use @ts-graphviz/parser , but the AST-related parts have been integrated into the ts-graphviz/ast module with a major upgrade of the ts-graphviz package.

See more detail on https://github.com/ts-graphviz/ts-graphviz#ts-graphvizast-module-

And we will deprecate @ts-graphviz/parser in the near future.

When integrating from @ts-graphviz/parser to ts-graphviz/ast, we made children instead of body property to improve integrity with the unified project, so it should be a smooth transition.

If you find a bug or have a feature request, please create an issue.

@ChristianMurphy
Copy link
Member Author

Thanks @kamiazya! 🙇
I'll refactor to pull in the latest version of ts-graphviz and leverage the new imports.

@ChristianMurphy
Copy link
Member Author

Closing in favor of #25

@ChristianMurphy ChristianMurphy deleted the rewrite-codebase branch July 28, 2023 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🗄 area/interface This affects the public interface 🕸️ area/tests This affects tests 🏗 area/tools This affects tooling ☂️ area/types This affects typings 🛠 blocked/wip This cannot progress yet, it’s being worked on 🧑 semver/major This is a change
Development

Successfully merging this pull request may close these issues.

3 participants