Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add govulncheck linter #1513

Merged
merged 2 commits into from
Oct 18, 2022
Merged

Conversation

mihaitodor
Copy link
Collaborator

@mihaitodor mihaitodor commented Oct 12, 2022

This is temporary while golangci/golangci-lint#3094 is being worked on here: golangci/golangci-lint#3199

Also, actions/setup-go added a check-latest flag that can be set to true to ensure that the latest matching release is pulled in if it's newer than the cached one. I enabled this because otherwise this linter will complain about vulnerabilities in the standard lib whenever there's a new patch version released until the cached version expires.

There's https://github.com/Templum/govulncheck-action which can also upload a vulnerability report to GitHub, but I don't think it's worth the hassle of maintaining that.

@mihaitodor mihaitodor requested a review from Jeffail as a code owner October 12, 2022 23:58
@mihaitodor mihaitodor force-pushed the add-govulncheck branch 5 times, most recently from c64a3b1 to 42d9be0 Compare October 13, 2022 00:57
@mihaitodor mihaitodor marked this pull request as draft October 13, 2022 01:34
@mihaitodor mihaitodor force-pushed the add-govulncheck branch 5 times, most recently from 475bc10 to 918c159 Compare October 13, 2022 10:47
@mihaitodor mihaitodor marked this pull request as ready for review October 13, 2022 10:47
This is temporary while golangci/golangci-lint#3094
is being worked on here: golangci/golangci-lint#3199
Also ensure that it installs the latest available matching Go
release.
Copy link
Collaborator

@Jeffail Jeffail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @mihaitodor!

@Jeffail Jeffail merged commit e2f901e into redpanda-data:main Oct 18, 2022
@mihaitodor mihaitodor deleted the add-govulncheck branch November 22, 2022 03:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants