Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DOC-883 Support for automated Go mod updates #243

Merged
merged 3 commits into from
Jan 20, 2025
Merged

DOC-883 Support for automated Go mod updates #243

merged 3 commits into from
Jan 20, 2025

Conversation

JakeSCahill
Copy link
Contributor

@JakeSCahill JakeSCahill commented Jan 16, 2025 •
edited
Loading

@JakeSCahill JakeSCahill requested a review from Deflaimun January 16, 2025 16:23
@netlify Netlify
Copy link

netlify bot commented Jan 16, 2025 •
edited
Loading

✅ Deploy Preview for docs-ui ready!

Name Link
🔨 Latest commit 9501fe8
🔍 Latest deploy log https://app.netlify.com/sites/docs-ui/deploys/678d0c5a87a36b0008a9567d
😎 Deploy Preview https://deploy-preview-243--docs-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Deflaimun Deflaimun requested a review from r-vasquez January 16, 2025 16:27
@Deflaimun
Copy link
Contributor

Adding @r-vasquez as a reviewer, as Go specialist.

@JakeSCahill JakeSCahill changed the title DOC-833 Support for automated Go mod updates DOC-883 Support for automated Go mod updates Jan 17, 2025
@JakeSCahill JakeSCahill mentioned this pull request Jan 17, 2025
Merged
r-vasquez
r-vasquez reviewed Jan 17, 2025
View reviewed changes
Copy link
Contributor

@r-vasquez r-vasquez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one small comment. I would also leave a small quick document (a readme maybe?) on how to trigger this action to update the dependencies and create the PR

.github/workflows/update-go-mod.yml Outdated Show resolved Hide resolved
JakeSCahill and others added 2 commits January 18, 2025 07:11
@JakeSCahill @r-vasquez
Apply suggestions from code review
4f07941 
Co-authored-by: Rogger Vasquez <59714880+r-vasquez@users.noreply.github.com>
@JakeSCahill
Update README.md
9501fe8
@JakeSCahill JakeSCahill requested a review from r-vasquez January 19, 2025 14:30
r-vasquez
r-vasquez approved these changes Jan 20, 2025
View reviewed changes
Copy link
Contributor

@r-vasquez r-vasquez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@JakeSCahill JakeSCahill merged commit fdb74da into main Jan 20, 2025
6 checks passed
@JakeSCahill JakeSCahill deleted the DOC-883 branch January 20, 2025 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@r-vasquez r-vasquez r-vasquez approved these changes

@Deflaimun Deflaimun Awaiting requested review from Deflaimun

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JakeSCahill @Deflaimun @r-vasquez