Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update properties for 24.1.7 #554

Merged
merged 5 commits into from
Jun 14, 2024
Merged

Update properties for 24.1.7 #554

merged 5 commits into from
Jun 14, 2024

Conversation

Deflaimun
Copy link
Contributor

@Deflaimun Deflaimun commented Jun 13, 2024

Description

Resolves https://github.com/redpanda-data/documentation-private/issues/
Review deadline:

Page previews

Checks

  • New feature
  • Content gap
  • Support Follow-up
  • Small fix (typos, links, copyedits, etc)

@Deflaimun Deflaimun requested a review from a team as a code owner June 13, 2024 18:59
Copy link

netlify bot commented Jun 13, 2024

Deploy Preview for redpanda-docs-preview ready!

Name Link
🔨 Latest commit 7dce70c
🔍 Latest deploy log https://app.netlify.com/sites/redpanda-docs-preview/deploys/666c6cccf85ce50008f1c228
😎 Deploy Preview https://deploy-preview-554--redpanda-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Deflaimun Deflaimun force-pushed the properties-24.1.7 branch from b043393 to 4e511cd Compare June 13, 2024 19:00
@Deflaimun
Copy link
Contributor Author

Created from #539 with only the 24.1.7 properties

@@ -425,6 +425,22 @@ Path to the API specifications for the HTTP Proxy API.

---

=== mode_mutability

Allow modifying mode.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This description is not helpful. Could we add what is mode and why would users want to modify it ?
Property found at src/v/pandaproxy/schema_registry/configuration.cc

cc @BenPope

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the feature: redpanda-data/redpanda#17952

When true, the Schema Registry and subjects can be changed between READONLY and READWRITE.


Allow modifying mode.

*Requires Restart:* No
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
*Requires Restart:* No
*Requires restart:* No


Allow modifying mode.

*Requires Restart:* No
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
*Requires Restart:* No
*Requires restart:* No


*Unit:* milliseconds

*Requires Restart:* No
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
*Requires Restart:* No
*Requires restart:* No


The recursion depth after which debug logging will be enabled automatically for the log reader.

*Requires Restart:* No
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
*Requires Restart:* No
*Requires restart:* No


Disable reusable preallocated buffers for LZ4 decompression.

*Requires Restart:* Yes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
*Requires Restart:* Yes
*Requires restart:* Yes

@@ -3624,7 +3678,7 @@ If the number of scheduled tick moves drops by this ratio, a new tick is schedul

=== partition_autobalancing_topic_aware

Enable topic-aware partition balancing, which balances a topic's partition replica count on each broker before balancing the cluster's overall partition count. This is helpful because different topics in a cluster can have vastly different load profiles.
If `true`, Redpanda will prioritize balancing a topic-wise number of partitions on each node, as opposed to balancing the total number of partitions. This should provide better balancing results if topics with diverse partition sizes and load profiles are present in the cluster.

*Requires Restart:* no
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
*Requires Restart:* no
*Requires restart:* no


Enables an additional step in leader election where a candidate is allowed to wait for all the replies from the node it requested votes from. This may introduce a small delay when recovering from failure but will prevent truncation if any of the replicas have more data than the majority.

*Requires Restart:* No
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
*Requires Restart:* No
*Requires restart:* No


Maximum desired number of readers cached per ntp. This a soft limit, meaning that a number of readers in cache may temporarily increase as cleanup is performed in the background.

*Requires Restart:* No
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
*Requires Restart:* No
*Requires restart:* No


Enables delete retention of consumer offsets topic. This is an internal-only configuration and should be enabled only after consulting with Redpanda support or engineers.

*Requires Restart:* Yes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
*Requires Restart:* Yes
*Requires restart:* Yes


Minimum number of active producers per virtual cluster.

*Requires Restart:* No
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
*Requires Restart:* No
*Requires restart:* No

@@ -139,6 +139,22 @@ To authenticate using access keys, see <<cloud_storage_access_key>>.

---

=== cloud_storage_disable_archiver_manager

Use legacy upload mode and do not start archiver_manager.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know anything about the archiver manager, but guessing this should be archiver_manager.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe it's an upcoming feature.

Copy link
Contributor

@micheleRP micheleRP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added some suggestions, then looks good!


Allow modifying mode.

*Requires Restart:* No
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is node config, restart is required.

Deflaimun and others added 4 commits June 14, 2024 13:09
@Deflaimun Deflaimun merged commit 8753b9b into main Jun 14, 2024
4 of 5 checks passed
@Deflaimun Deflaimun deleted the properties-24.1.7 branch June 14, 2024 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants