-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ducktape: Save command line on start and add it to HTML report #27
Conversation
i'm seeing error in the python check |
Python py38 check failed due to random port that it tries to use is already in use (real reason). And it is completely unrelated to this code |
i wonder when/how this started to fail. we should create a ticket to fix. Maybe synchronizing with upstream would take care of it (?) |
/recheck |
Rebased to master, fixed one flake8 error and bumped pyyaml version to 6.0.1 according to this issue |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this needs a rebase with the tip of master
. looks like dd1fe9e is a merge commit. rebase will have the git commits stacked on top of master
which will help reason about the differences with upstream.
EDIT: i think this PR should have 2 commits but it shows a lot more of the older ones which was a hint to me it was not rebased.
other than that, changes lgtm.
I personally do not know what to do next. I am lost in the branches and where should what go :) |
i just tried to rebase against master with
and it looks like git has conflict with each one of the 48 commits in this PR which i feel is unnecessary to resolve because it is pretty much just doing what was done in https://github.com/redpanda-data/devprod/issues/332 all over again. i think it would be easier to open a new PR to |
259bef9
to
8117129
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
8117129
to
51ef2b8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
after this merges, be sure to update https://github.com/redpanda-data/redpanda/blob/dev/tests/setup.py with the new git commit from master
branch
or update redpanda-data/redpanda#13116 |
With minimal changes to structure and test flow, added command line as it was in
sys.argv