default_topic_replications is not respected if provided
#1501
Comments
chrisseto
added a commit
that referenced
this issue
Sep 11, 2024
Prior to this commit, `default_topic_replications` could be unexpectedly modified by the chart based on some internal math. This behavior was opaque and frustrating to users attempting to finely tune their cluster configuration. This commit removes the default value of `default_topic_replications` in `values.yaml` and instead sets it within the chart only if `default_topic_replications` is NOT provided. This preserves the existing behavior of setting `default_topic_replications` to 3 or 1 based on `statefulset.replicas`. Fixes #1501 K8S-334
chrisseto
added a commit
that referenced
this issue
Sep 12, 2024
Prior to this commit, `default_topic_replications` could be unexpectedly modified by the chart based on some internal math. This behavior was opaque and frustrating to users attempting to finely tune their cluster configuration. This commit removes the default value of `default_topic_replications` in `values.yaml` and instead sets it within the chart only if `default_topic_replications` is NOT provided. This preserves the existing behavior of setting `default_topic_replications` to 3 or 1 based on `statefulset.replicas`. Fixes #1501 K8S-334
chrisseto
added a commit
that referenced
this issue
Sep 12, 2024
Prior to this commit, `default_topic_replications` could be unexpectedly modified by the chart based on some internal math. This behavior was opaque and frustrating to users attempting to finely tune their cluster configuration. This commit removes the default value of `default_topic_replications` in `values.yaml` and instead sets it within the chart only if `default_topic_replications` is NOT provided. This preserves the existing behavior of setting `default_topic_replications` to 3 or 1 based on `statefulset.replicas`. Fixes #1501 K8S-334
chrisseto
added a commit
that referenced
this issue
Sep 12, 2024
Prior to this commit, `default_topic_replications` could be unexpectedly modified by the chart based on some internal math. This behavior was opaque and frustrating to users attempting to finely tune their cluster configuration. This commit removes the default value of `default_topic_replications` in `values.yaml` and instead sets it within the chart only if `default_topic_replications` is NOT provided. This preserves the existing behavior of setting `default_topic_replications` to 3 or 1 based on `statefulset.replicas`. Fixes #1501 K8S-334
chrisseto
added a commit
that referenced
this issue
Sep 13, 2024
Prior to this commit, `default_topic_replications` could be unexpectedly modified by the chart based on some internal math. This behavior was opaque and frustrating to users attempting to finely tune their cluster configuration. This commit removes the default value of `default_topic_replications` in `values.yaml` and instead sets it within the chart only if `default_topic_replications` is NOT provided. This preserves the existing behavior of setting `default_topic_replications` to 3 or 1 based on `statefulset.replicas`. Fixes #1501 K8S-334
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
@clee and @ncole noticed that the chart will override
default_topic_replicationsto something very similar to.replicaseven if it's explicitly set.Clearly we should not be doing this.
JIRA Link: K8S-334
The text was updated successfully, but these errors were encountered: