remove typing of cloud_storage_enabled
#144
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
c583b32 remove typing of
cloud_storage_enabled
When
v1alpha2
was added it was set as the storage version with a"none" conversion strategy. Due to the type change on the
cloud_storage_enabled
field, this resulted in a litany of issueslargely revolving around type validation at the Kube API level.
This commit changes the definitions
v1alpha1
andv1alpha2
to be theexact same, but removes type validation of the
cloud_storage_enabled
field. This ensures that both
v1alpha1
andv1alpha2
versions areaccepted by Kubernetes and are appropriately handled by our controllers.
The updated data type will now correctly marshal both string and boolean
JSON types to booleans values which fixes any incompatibilities with the
helm chart's now correctly typed
cloud_storage_enabled
field.See also:
110831b
redpanda-data/helm-charts@b733738