Support setting priority class name in broker pods #154
Conversation
|
|
paulzhang97
force-pushed
the
paulz/priority-class
branch
from
ad2beed
to
27bf04d
Compare
paulzhang97
force-pushed
the
paulz/priority-class
branch
from
27bf04d
to
181e149
Compare
paulzhang97
changed the title
| @@ -104,6 +104,8 @@ type ClusterSpec struct { | |||
| // Replicas determine how big the cluster will be. | |||
| // +kubebuilder:validation:Minimum=0 | |||
| Replicas *int32 `json:"replicas,omitempty"` | |||
| // PriorityClassName is the name of PriortyClass. | |||
There was a problem hiding this comment.
nit: can this comment be expanded ever so slightly? Something like PriorityClassName is used to set the PodSpec.PriorityClassName of the redpanda Statefulset?
| @@ -1071,6 +1071,9 @@ spec: | |||
| you can read more in https://kubernetes.io/docs/tasks/run-application/configure-pdb/ | |||
| x-kubernetes-int-or-string: true | |||
| type: object | |||
| priorityClassName: | |||
| description: PriorityClassName is the name of PriortyClass. | |||
| @@ -284,6 +286,25 @@ func (r *Cluster) validateScaling() field.ErrorList { | |||
| return allErrs | |||
| } | |||
|
|
|||
| func (r *Cluster) validatePriorityClassName() field.ErrorList { | |||
There was a problem hiding this comment.
IMO there's no need to validate this. This error will eventually be encountered when pods are trying to be scheduled. It's more of the "kubernetes way" to let misconfigurations fail in a backoff loop rather than validate them up front; for better or worse.
I don't have super strong feelings here if the existing validators do something similar.
There was a problem hiding this comment.
Understood. I agree. Just follow the existing pattern. I will keep it.
| @@ -104,6 +104,8 @@ type ClusterSpec struct { | |||
| // Replicas determine how big the cluster will be. | |||
| // +kubebuilder:validation:Minimum=0 | |||
| Replicas *int32 `json:"replicas,omitempty"` | |||
| // PriorityClassName is the name of PriortyClass. | |||
There was a problem hiding this comment.
nit: can this comment be expanded ever so slightly? Something like PriorityClassName is used to set the PodSpec.PriorityClassName of the redpanda Statefulset?
Add
priorityClassNametoclusterCRD for setting priority class in Redpanda broker pods.