Correct PodAntiAffinity typing #163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RafalKorepta
approved these changes
Jun 21, 2024
chrisseto
force-pushed
the
chris/pod-anti-affinity
branch
from
56c8f66
to
5ff77ad
Compare
Prior to this commit, Statefulset.PodAntiAffinity was incorrectly typed as a `corev1.PodAntiAffinity`. Despite the seemingly correct naming, this is not the type expected by the helm chart nor the documented type. This commit corrects the typing to use the `PodAntiAffinity` struct, which was vexingly defined but not utilized.
chrisseto
force-pushed
the
chris/pod-anti-affinity
branch
from
5ff77ad
to
3fd757b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit, Statefulset.PodAntiAffinity was incorrectly typed as a
corev1.PodAntiAffinity. Despite the seemingly correct naming, this is not the type expected by the helm chart nor the documented type.This commit corrects the typing to use the
PodAntiAffinitystruct, which was vexingly defined but not utilized.