Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update CRD and fix minor issues #164

Merged
merged 2 commits into from
Jun 26, 2024
Merged

Update CRD and fix minor issues #164

merged 2 commits into from
Jun 26, 2024

Commits on Jun 25, 2024

  1. update and consolidate golangci-lint config 

    Prior to this commit golangci-lint was installed by task and run in buildkite,
installed by an action and run in github actions, and there existed two `.golangci.yml` files.

This scattered configuration was frustrating to deal with and resulted in
linting rules being applied inconsistently (aside from the golangci's own
inconsistency).

This commit collapses the configurations down to a single file in
`src/go/k8s/.golangci.yml`, updates the configurations to fix some
deprecations, removes the github action for linting in favor of builtkite,
installed golangci-lint via nix, and fixes pre-existing errors discovered by
fixing the configuration spaghetti.
    @chrisseto
    chrisseto committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    e2560d7 View commit details
    Browse the repository at this point in the history

  2. Update CRD and fix minor issues 

    This commit updates `RedpandaClusterSpec` to support the `TrustStore` option
that was added to the helm chart in
redpanda-data/helm-charts@f539d8f.

Additionally, it adds a regression test to find divergences between the CRD and
helm chart. The majority of this test case is currently disabled due to many
such divergences.

Finally, this commit also contains a handful of small fixes that were found in
the above test case:
- Added `omitempty` to `Auth.SASL`, `RedpandaMemory.{Memory,ReserveMemory}`.
- Deprecated `ListenerTLS.SecretRef` as it's not a real value.
- Deprecated `UsageStats.Organization` as it's been removed from the helm chart.
- Removed unused types `Limits`, `Requests`, `TopologySpreadConstraintsItems`.
- Corrected `TopologySpreadConstraint` to be a slice. (See note)

Technically, changing the type of `TopologySpreadConstraint` is a breaking
change. However, specifying it would have caused deployments to immediately
break. Therefore it's reasonably safe to assume this change will not affect any
users.

Changing the casing of `FullNameOverride` is being deferred as it is possible
to specify it without breaking deployments and changing the casing could result
in breakages as that would be seen as a field addition and removal from the API
perspective.
    @chrisseto
    chrisseto committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    81ff038 View commit details
    Browse the repository at this point in the history